Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v100.4.0 #2936

Merged
merged 4 commits into from
Dec 14, 2023
Merged

feat: v100.4.0 #2936

merged 4 commits into from
Dec 14, 2023

Conversation

janhenrikoverland
Copy link
Collaborator

v100.4.0

dhis2-bot and others added 4 commits November 12, 2023 17:43
Automatically merged.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Automatically merged.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* chore(deps): bump tar from 4.4.13 to 4.4.19 (#1946)

Bumps [tar](https://github.com/npm/node-tar) from 4.4.13 to 4.4.19.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v4.4.13...v4.4.19)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: support non-gregorian fixed periods (#2233)

* feat: support non-gregorian fixed periods

* test: fix test failing due to change in single value behaviour

---------

Co-authored-by: Jan Henrik Øverland <[email protected]>

* fix: dependency updates (#2243)

* fix: update cli-app-scripts and analytics deps

* chore: configure continuous delivery workflows (#2254)

There are 4 workflows:

verify PR (dhis2-verify-app.yml)
-- build, lint, test, e2e-prod

verify commit to dev (dhis2-verify-app.yml)
-- build, lint, test, e2e-prod, report-failure-to-slack

verify commit to master (dhis2-verify-app.yml)
-- build, lint, test, e2e-prod, release, report-failure-to-slack

nightly (nightly.yml)
-- e2e-dev, report-failure

In addition:

* e2e-prod and e2e-dev are reusable workflows and are called from dhis2-verify-app and nightly.
* removed uses: c-hive/gha-yarn-cache@v1 since it is deprecated and setup-node handles that work.
* updated action versions and node versions
* cypress test version tagging for features and bugs has been added (copied from line-list)

* feat: single value background color change based upon legend (DHIS2-13702) (#2223)

* feat: implement data icon option for SV visualization (DHIS2-10496) (#2236)

* fix: do not pass a boolean for icons when saving

If the option is not set, and thus its value is the same as the default
(false) remove it from the current object to avoid sending a boolean
value that the backend does not expect.
This was causing any save to return 500.

* fix: hide icon from visualization when option is toggled

This didn't work before because the icons option was removed from the
options object, but when the current object was merged with
the new options, it retained the original value.

* fix: fetch data element icon and pass it in extraOptions

This is needed for SV visualizations when the "Show data item icon"
options is checked and an icon is assigned to the dx dimension in the
maintenance app.
In that case the icon's SVG is fetched from the API and passed to the
visualization API in the extraOptions object.
The SVG generator embeds the icon in the SVG so it appears on the side
of the value.

* chore: manually bump deps (#2543)

* chore: upgrade cypress to v12 and adjust project to it

* chore: remove videos

* chore: switch test server to debug (test.e2e is broken/slow)

* chore: revert the test server changes and move to a separate PR

* test: refactor clickCheckbox to check/uncheckCheckbox

* test: add helper functions for totals options

* test: add tests for cumulativeValues option in PT

* refactor: allow non toggleable select to be disabled

* refactor: allow checkbox options to be disabled

* feat: disable option when cumulativeValues is checked in PT DHiS2-15728

* refactor: add helper text when used in PT DHIS2-15727

* feat: disabled options based on cumulativeValues in PT DHIS2-15728

* chore: update pot file

* feat: handle disabled option in Redux store

* refactor: revert changes to option components

* feat: handle disabled and helpText props for disabled options

* refactor: avoid extra prop and detect visType internally

* feat: remove disabled before passing object to visualization generator

* refactor: remove unnecessary code

* refactor: streamlined code

* fix: set disabledOptions on AO loading and vis type switching

* fix: fix bug which cause current to loose props

* chore: update pot file

* refactor: rename variable for clarity

* chore: fix rebase conflict resolutions

* fix: avoid crash when visualization object is empty (ie. New)

* refactor: allow disabled to be passed as prop

* refactor: allow legend related option to be disabled

* feat: disable legend option when cumulative values is enabled

* refactor: add styles for titles of disabled sections

* chore: regenerate pot file

* fix: avoid visualization flashing when changing options

Move the filtering of disabled options in the plugin, which is needed
anyway to have the visualization looking the same also in dashboards.

* refactor: simplify code for passing displayProperty

* refactor: avoid involuntary changes to current in Redux store

We still need to clone the object, and use it also for the various
checks on options.

* test: enhance tests, options and sorting

* test: use current year instead of hardcode it

* chore: use alpha version of analytics

* docs: add PT to the list of vis types for cumulative values

* chore: fix linting error

* chore(analytics): add support for cumulative values

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mozafar <[email protected]>
Co-authored-by: Jan Henrik Øverland <[email protected]>
Co-authored-by: Jen Jones Arnesen <[email protected]>
Co-authored-by: Martin <[email protected]>
Co-authored-by: HendrikThePendric <[email protected]>
@dhis2-bot
Copy link
Contributor

@dhis2-bot dhis2-bot temporarily deployed to netlify December 14, 2023 15:47 Inactive
Copy link

cypress bot commented Dec 14, 2023

126 failed tests on run #2587 ↗︎

126 322 1 5 Flakiness 0

Details:

feat: cumulative values in PT (DHIS2-5497) (#2746)
Project: Data Visualizer App Commit: bff69ab9ce
Status: Failed Duration: 37:41 💡
Started: Dec 14, 2023 4:35 PM Ended: Dec 14, 2023 5:13 PM
Failed  dimensions/data.cy.js • 64 failed tests • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Data dimension > initial state > navigates to the start page Screenshots Video
Data dimension > initial state > no items are selected Screenshots Video
Data dimension > initial state > an item can be unselected by double click Screenshots Video
Data dimension > initial state > an item can be unselected by button Screenshots Video
Data dimension > selecting all and fetching more > all items can be unselected Screenshots Video
Data dimension > global search > search result is maintained when switching data type Screenshots Video
Data dimension > global search > search displays a correct error message Screenshots Video
Data dimension > global search > search result can be cleared Screenshots Video
Data dimension > global search > modal is closed Screenshots Video
Data dimension > Indicators > opens the data dimension modal Screenshots Video
The first 10 failed tests are shown, see all 64 tests in Cypress Cloud.
Failed  options/legend.cy.js • 9 failed tests • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Options - Legend > applies different styles of legend to a Column chart Screenshots Video
Options - Legend > applies different styles of legend to a Single Value chart Screenshots Video
Options - Legend > applies different styles of legend to a Gauge chart Screenshots Video
Options - Legend > applies different styles of legend to a Stacked Column chart Screenshots Video
Options - Legend > applies different styles of legend to a Pivot table Screenshots Video
Options - Legend > applies the legend when vis type is changed from Pivot table to Gauge Screenshots Video
Options - Legend > applies the legend when vis type is changed from Pivot table to Single value Screenshots Video
Options - Legend > applies the legend key setttings when vis type changes: Column -> Pivot table -> Gauge -> Single value Screenshots Video
Options - Legend > does not apply non-applicable options when Column switched to Area Screenshots Video
Failed  new.cy.js • 9 failed tests • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
creating a new AO > create AO of type Pivot table Screenshots Video
creating a new AO > create AO of type Column Screenshots Video
creating a new AO > create AO of type Stacked column Screenshots Video
creating a new AO > create AO of type Bar Screenshots Video
creating a new AO > create AO of type Stacked bar Screenshots Video
creating a new AO > create AO of type Line Screenshots Video
creating a new AO > create AO of type Area Screenshots Video
creating a new AO > create AO of type Stacked area Screenshots Video
creating a new AO > create AO of type Pie Screenshots Video
Failed  dimensions/calculations.cy.js • 1 failed test • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Calculations > initial state loads correctly Screenshots Video
Failed  open.cy.js • 43 failed tests • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
opening a saved AO > navigates to the start page Screenshots Video
opening a saved AO > Column > opens a saved AO Screenshots Video
opening a saved AO > Column > replaces the selected period Screenshots Video
opening a saved AO > Column > resets to a new AO Screenshots Video
opening a saved AO > Bar > opens a saved AO Screenshots Video
opening a saved AO > Bar > replaces the selected period Screenshots Video
opening a saved AO > Bar > resets to a new AO Screenshots Video
opening a saved AO > Stacked column > opens a saved AO Screenshots Video
opening a saved AO > Stacked column > replaces the selected period Screenshots Video
opening a saved AO > Stacked column > resets to a new AO Screenshots Video
The first 10 failed tests are shown, see all 43 tests in Cypress Cloud.

Review all test suite changes for PR #2936 ↗︎

Copy link

cypress bot commented Dec 14, 2023

255 failed and 1 flaky tests on run #2586 ↗︎

255 200 1 1 Flakiness 1

Details:

Merge bff69ab into d404c45...
Project: Data Visualizer App Commit: 626a0c931b ℹ️
Status: Failed Duration: 53:41 💡
Started: Dec 14, 2023 4:25 PM Ended: Dec 14, 2023 5:19 PM
Failed  dimensions/data.cy.js • 50 failed tests • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Data dimension > Indicators > group can be changed to "Facility infrastructure" Screenshots Video
Data dimension > Indicators > the first item can be selected Screenshots Video
Data dimension > Indicators > search displays a correct error message Screenshots Video
Data dimension > Indicators > selection and filter can be reset Screenshots Video
Data dimension > Indicators > modal is closed Screenshots Video
Data dimension > Data elements > opens the data dimension modal Screenshots Video
Data dimension > Data elements > switches to Data elements Screenshots Video
Data dimension > Data elements > group select is visible Screenshots Video
Data dimension > Data elements > more items are fetched when scrolling down Screenshots Video
Data dimension > Data elements > an item can be selected Screenshots Video
The first 10 failed tests are shown, see all 50 tests in Cypress Cloud.
Failed  dimensions/calculations.cy.js • 1 failed test • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Calculations > validates formulas Screenshots Video
Failed  options/limitValues.cy.js • 1 failed test • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
limit values > equal value display correctly Screenshots Video
Failed  save.cy.js • 2 failed tests • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
saving an AO > "save" and "save as" for a saved AO created by you Screenshots Video
saving an AO > "save" a copied AO created by others works after editing Screenshots Video
Failed  visTypes/scatter.cy.js • 16 failed tests • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
using a Scatter chart > navigates to a new Scatter chart Screenshots Video
using a Scatter chart > shows an error message when vertical and horizontal isn't selected Screenshots Video
using a Scatter chart > adds a vertical item and shows an error message Screenshots Video
using a Scatter chart > adds a horizontal item and displays a chart Screenshots Video
using a Scatter chart > selects org unit level Facility Screenshots Video
using a Scatter chart > Data is locked to Vertical Screenshots Video
using a Scatter chart > Data is locked to Horizontal Screenshots Video
using a Scatter chart > Org units is locked to Points Screenshots Video
using a Scatter chart > swaps vertical with horizontal Screenshots Video
using a Scatter chart > adds a second item to horizontal and displays warning messages Screenshots Video
The first 10 failed tests are shown, see all 16 tests in Cypress Cloud.

The first 5 failed specs are shown, see all 8 specs in Cypress Cloud.

Flakiness  cypress/integration/options/legend.cy.js • 1 flaky test • e2e-chrome-parallel-2.40

View Output

Test Artifacts
Options - Legend > applies different styles of legend to a Stacked Column chart Screenshots

Review all test suite changes for PR #2936 ↗︎

@janhenrikoverland janhenrikoverland merged commit a8e0f66 into master Dec 14, 2023
21 of 29 checks passed
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants