fix: v100.3.1 #2907
Merged
fix: v100.3.1 #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To follow cypress best practice, consolidate assertions into single tests when they represent a single logical user journey Positive side effects (in addition to those listed in the best practice page): * less tests contributing to our monthly cypress subscription total * less skewed impression of coverage With these changes the number of tests has gone down from 637 to 569
Note: no assertions were harmed during the making of this PR. What has changed: Every describe under the top level describe has been changed to an it. All the its within the former describe have been removed and their title converted to a comment or a cy.log. Comments were converted to cy.log to make it easier to locate eventual errors in the cypress dashboard output.
add BRANCH_NAME and PR_TITLE as RP attributes
dhis2/workflows#46 merged [CI_BUILD_ID] dhis2/workflows#47 merged [BRANCH_NAME and PR_TITLE]
chore: use reportportal fork
fix: color set update
|
🚀 Deployed on https://pr-2907--dhis2-data-visualizer.netlify.app |
1 flaky test on run #2529 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| creating a new AO > create AO of type Column |
Screenshots
|
|
Review all test suite changes for PR #2907 ↗︎
Passing run #2530 ↗︎
Details:
Review all test suite changes for PR #2907 ↗︎ |
|||||||||||||||
|
🎉 This PR is included in version 100.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See logs for list of fixes.