chore: consolidate legend tests #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2897--dhis2-data-visualizer.netlify.app |
Passing run #2521 ↗︎
Details:
Review all test suite changes for PR #2897 ↗︎ |
|||||||||||||||
martinkrulltott
approved these changes
Nov 6, 2023
|
🎉 This PR is included in version 100.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: no assertions were harmed during the making of this PR.
What has changed: Every
describeunder the top leveldescribehas been changed to anit. All theits within the formerdescribehave been removed (their title converted to a comment or a cy.log). Comments were converted to cy.log to make it easier to locate eventual errors in the cypress dashboard output.Worth discussing whether each test is now doing too much, but I would argue that a test should always do its own set up. In that case, each test does encapsulate a logical set of user actions that belong together.
Number of tests reduced from: ~570 to ~450 (the numbers vary)