Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid undefined in totals (DHIS2-14511) [v38] #2869

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Oct 5, 2023

Fixes DHIS2-14511

Requires dhis2/analytics#1585


Key features

  1. fix undefined in PT totals when value is 0 (bump analytics dependency)

Description

Backport.
See original fix here.

@dhis2-bot
Copy link
Contributor

@cypress
Copy link

cypress bot commented Oct 5, 2023

Passing run #2442 ↗︎

0 583 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 9d0f3a6 into 91a5654...
Project: Data Visualizer App Commit: cb83a56151 ℹ️
Status: Passed Duration: 23:10 💡
Started: Oct 5, 2023 1:00 PM Ended: Oct 5, 2023 1:23 PM

Review all test suite changes for PR #2869 ↗︎

@janhenrikoverland janhenrikoverland changed the title fix: avoid undefined in totals DHIS2-14511 v38 fix: avoid undefined in totals (DHIS2-14511) [v38] Oct 11, 2023
@edoardo edoardo merged commit 6ee4a1f into 38.x Oct 12, 2023
6 checks passed
@edoardo edoardo deleted the backport/pt-undefined-totals-DHIS2-14511-v38 branch October 12, 2023 07:53
dhis2-bot added a commit that referenced this pull request Oct 12, 2023
## [38.3.22](v38.3.21...v38.3.22) (2023-10-12)

### Bug Fixes

* avoid undefined in totals DHIS2-14511 ([#2869](#2869)) ([6ee4a1f](6ee4a1f))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 38.3.22 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants