fix: avoid duplicate path in get link URL DHIS2-14535 [v39] #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardo
changed the title
|
🚀 Deployed on https://pr-2820--dhis2-data-visualizer.netlify.app |
edoardo
changed the title
Passing run #2463 ↗︎
Details:
Review all test suite changes for PR #2820 ↗︎ |
|||||||||||||||
* test: add tests for stacked column legend * chore: bump analytics to latest * test: change bleed test to Area (since Stacked column is now actually supported) (cherry picked from commit bbb0c11)
edoardo
force-pushed
the
backport/get-link-fix-DHIS2-14535-v39
branch
from
1aefcd2 to
4136133
Compare
martinkrulltott
approved these changes
Oct 13, 2023
dhis2-bot
added a commit
that referenced
this pull request
Oct 17, 2023
## [39.2.17](v39.2.16...v39.2.17) (2023-10-17) ### Bug Fixes * avoid duplicate path in get link URL DHIS2-14535 [v39] ([#2820](#2820)) ([2925600](2925600))
|
🎉 This PR is included in version 39.2.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-14535
Key features
Description
The fix is actually in
@dhis2/analytics. This PR is for bumping the dependency to the correct version with the fix.Screenshots
Before:
After: