Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add release success and improved fail slack message #2777

Closed
wants to merge 5 commits into from

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented Sep 14, 2023

There are 2 types of commits to the master branch:

  1. merge commits that contain the actual code changes
  2. the "chore (release)" commit that updates the version in package.json and adds the release notes

These 2 commits to master should have slightly different workflows

  1. merge commits (code)
  • check code quality using: lint, test, build, e2e
  • create the "chore (release)" commit
  • report failure if any of the previous checks failed
  1. "chore (release)" commit
  • build (bc of new package.json version)
  • create the new tag
  • report failure if any of the previous steps failed
  • report success if the tag was created

Another way to describe this:

  • PR commit to master
    build, lint, test, e2e, release, release-failure-message

  • chore (release) commit to master
    build, tag, release-failure-message or release-success-message

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Sep 14, 2023

@dhis2-bot dhis2-bot temporarily deployed to netlify September 14, 2023 14:14 Inactive
@cypress
Copy link

cypress bot commented Sep 15, 2023

Passing run #2539 ↗︎

0 453 1 0 Flakiness 0

Details:

Merge 6b17077 into ba1fcf5...
Project: Data Visualizer App Commit: 78695946ad ℹ️
Status: Passed Duration: 20:15 💡
Started: Nov 9, 2023 11:27 PM Ended: Nov 9, 2023 11:47 PM

Review all test suite changes for PR #2777 ↗︎

@jenniferarnesen jenniferarnesen self-assigned this Sep 15, 2023
@jenniferarnesen jenniferarnesen marked this pull request as draft September 15, 2023 12:04
@dhis2-bot dhis2-bot temporarily deployed to netlify November 1, 2023 12:07 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 9, 2023 14:08 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 9, 2023 15:12 Inactive
@jenniferarnesen jenniferarnesen marked this pull request as ready for review November 10, 2023 15:02
@dhis2-bot dhis2-bot temporarily deployed to netlify November 13, 2023 01:31 Inactive
@jenniferarnesen jenniferarnesen marked this pull request as draft November 13, 2023 01:34
@jenniferarnesen
Copy link
Collaborator Author

Different approach needed

@jenniferarnesen jenniferarnesen deleted the chore/report-release-success branch March 21, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants