fix: legend sets fail to load in table with data dimension in the row (DHIS2-12830) #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2753--dhis2-data-visualizer.netlify.app |
21 failed tests on run #2443 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Data dimension > initial state > navigates to the start page |
Output
Screenshots
Video
|
|
options/legend.cy.js • 1 failed test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| Options - Legend > Applying a legend: Column > navigates to the start page and adds data items |
Output
Screenshots
Video
|
|
options/limitValues.cy.js • 1 failed test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| limit values > min and max value display correctly |
Output
Screenshots
Video
|
|
dimensions/calculations.cy.js • 1 failed test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| Calculations > initial state loads correctly |
Output
Screenshots
Video
|
|
open.cy.js • 1 failed test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| opening a saved AO > navigates to the start page |
Output
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 21 specs in Cypress Cloud.
Review all test suite changes for PR #2753 ↗︎
janhenrikoverland
approved these changes
Sep 27, 2023
martinkrulltott
changed the title
martinkrulltott
added a commit
that referenced
this pull request
Nov 3, 2023
martinkrulltott
added a commit
that referenced
this pull request
Nov 3, 2023
|
🎉 This PR is included in version 100.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-12830
Key features
datais inrowsDescription
Applying a legend previously required
datato be incolumns. This was probably a targeting other vis types and shouldn't have been applied to PT (which use bothcolumnsandrowsinterchangeably). This requirement has been bypassed by letting PT havedatain either.Screenshots
before
after
