test: change item for testing dynamic dimensions

dhis2 · Feb 23, 2024 · 7970dcf · 7970dcf
1 parent 3b4463d
commit 7970dcf
Showing 1 changed file with 12 additions and 14 deletions.
diff --git a/cypress/integration/dimensions/dynamic.cy.js b/cypress/integration/dimensions/dynamic.cy.js
@@ -20,27 +20,25 @@ import {
     expectDimensionToHaveItemAmount,
 } from '../../elements/layout.js'
 import { goToStartPage } from '../../elements/startScreen.js'
-import { TEST_DATA_ELEMENTS } from '../../utils/data.js'
-import { getRandomArrayItem } from '../../utils/random.js'
 import { expectWindowConfigSeriesToHaveLength } from '../../utils/window.js'
 
-const TEST_DATA_ELEMENT_NAME = getRandomArrayItem(TEST_DATA_ELEMENTS).name
 const TEST_DYNAMIC_DIMENSION = {
     id: 'J5jldMd8OHv',
     name: 'Facility type',
     itemAmount: 5,
 }
 
 describe(`Dynamic dimension - ${TEST_DYNAMIC_DIMENSION.name}`, () => {
-    it('navigates to the start page and adds a data item', () => {
+    it('can add and remove items, which persist after saving', () => {
+        cy.log('navigates to the start page and adds a data item')
         goToStartPage()
         openDimension(DIMENSION_ID_DATA)
-        selectDataElements([TEST_DATA_ELEMENT_NAME])
+        selectDataElements(['ANC 2nd visit'])
         clickDimensionModalUpdateButton()
         expectVisualizationToBeVisible(VIS_TYPE_COLUMN)
-    })
-    const TEST_ITEM = 'Hospital'
-    it('adds an item manually', () => {
+
+        const TEST_ITEM = 'Hospital'
+        cy.log('adds an item manually')
         openDimension(TEST_DYNAMIC_DIMENSION.id)
         expectDimensionModalToBeVisible(TEST_DYNAMIC_DIMENSION.id)
         expectManualSelectionToBeChecked()
@@ -49,8 +47,8 @@ describe(`Dynamic dimension - ${TEST_DYNAMIC_DIMENSION.name}`, () => {
         expectVisualizationToBeVisible(VIS_TYPE_COLUMN)
         expectWindowConfigSeriesToHaveLength(1)
         expectDimensionToHaveItemAmount(TEST_DYNAMIC_DIMENSION.id, 1)
-    })
-    it('adds all items automatically', () => {
+
+        cy.log('adds all items automatically')
         openDimension(TEST_DYNAMIC_DIMENSION.id)
         expectDimensionModalToBeVisible(TEST_DYNAMIC_DIMENSION.id)
         expectManualSelectionToBeChecked()
@@ -60,8 +58,8 @@ describe(`Dynamic dimension - ${TEST_DYNAMIC_DIMENSION.name}`, () => {
         expectVisualizationToBeVisible(VIS_TYPE_COLUMN)
         expectWindowConfigSeriesToHaveLength(TEST_DYNAMIC_DIMENSION.itemAmount)
         expectDimensionToHaveAllItemsSelected(TEST_DYNAMIC_DIMENSION.id)
-    })
-    it('switches back to manual and previous item is presisted', () => {
+
+        cy.log('switches back to manual and previous item is presisted')
         openDimension(TEST_DYNAMIC_DIMENSION.id)
         expectDimensionModalToBeVisible(TEST_DYNAMIC_DIMENSION.id)
         expectAutomaticSelectionToBeChecked()
@@ -72,8 +70,8 @@ describe(`Dynamic dimension - ${TEST_DYNAMIC_DIMENSION.name}`, () => {
         expectVisualizationToBeVisible(VIS_TYPE_COLUMN)
         expectWindowConfigSeriesToHaveLength(1)
         expectDimensionToHaveItemAmount(TEST_DYNAMIC_DIMENSION.id, 1)
-    })
-    it('switches back to automatic, saving, the selection is presisted', () => {
+
+        cy.log('switches back to automatic, saving, the selection is presisted')
         openDimension(TEST_DYNAMIC_DIMENSION.id)
         expectDimensionModalToBeVisible(TEST_DYNAMIC_DIMENSION.id)
         expectManualSelectionToBeChecked()