fix: merge to master #2405
dhis2-verify-commits.yml
on: pull_request
lint-pr-title
1m 4s
lint-commits
1m 9s
Annotations
1 error and 11 warnings
lint-commits
You have commit messages with errors
⧗ input: fix: plugin flashes when interacting with Interpretations modal (#3017)
Fixes DHIS2-15570
Fixes DHIS2-17137
Prevent re-requests for analytics, and resulting re-renders that were giving a flashing effect.
* InterpretationModal: memoize the callback to avoid a re-render due to a "new" function
being passed with each render of InterpretationModal.
The effect of this change is minor, probably just 1 rerender
* VisualizationPlugin: ensure that the size of the plugin is set when it is coming
from the modal so that when changing the width of the viewport,
the visualization adjusts its size accordingly. (Previously this "worked" but only
because of all the re-fetch/re-renders)
* VisualizationPluginWrapper: need to listen to the individual properties,
rather than the whole props object since that was triggering lots of unnecessary re-fetch/renders.
* set the max-height to respect viewport so that vertical resize causes the chart to adjust accordingly
✖ body's lines must not be longer than 100 characters [body-max-line-length]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
|
lint-pr-title
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, c-hive/gha-yarn-cache@v1, JulienKode/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
lint-pr-title
The following actions uses node12 which is deprecated and will be forced to run on node16: c-hive/gha-yarn-cache@v1, JulienKode/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
lint-pr-title
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
lint-pr-title
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
lint-pr-title
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
lint-commits
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, c-hive/gha-yarn-cache@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
lint-commits
The following actions uses node12 which is deprecated and will be forced to run on node16: c-hive/gha-yarn-cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
lint-commits
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
lint-commits
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
lint-commits
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
lint-commits
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|