-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dashboard view mode design changes #3095
Conversation
🚀 Deployed on https://pr-3095.dashboard.netlify.dhis2.org |
@cooper-joe I fixed a bunch of merge conflicts that came up after merging Mozafar's rtl PR. You might want to do a check of the affected css files: Content.module.css |
There is a new design coming in PR #3156 that renders this PR obsolete. |
Implements UX-173
Key features
TitleBar
component to remain visible while scrolling a dashboard.TitleBar
components to reduce visual noise.Description
This PR implements changes to the Dashboard view mode to make it easier to understand which dashboard is currently selected. Visual design changes also reduce visual noise.
(This PR supersedes #2210, which had become stale and had an unfixable-to-me bug with the progressive loading.)
TODO
StarDashboard
button to a different component.control bar rows
. This was very difficult to get right, so I think it may be off somehow.Screenshots
Before:
After:
Before:
After:
Before:
After: