Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dashboard view mode design changes #3095

Closed
wants to merge 7 commits into from
Closed

Conversation

cooper-joe
Copy link
Member

@cooper-joe cooper-joe commented Sep 25, 2024

Implements UX-173


Key features

  1. Adjusts design of the TitleBar component to remain visible while scrolling a dashboard.
  2. Adjusts design of TitleBar components to reduce visual noise.

Description

This PR implements changes to the Dashboard view mode to make it easier to understand which dashboard is currently selected. Visual design changes also reduce visual noise.
(This PR supersedes #2210, which had become stale and had an unfixable-to-me bug with the progressive loading.)


TODO

  • Re-implement the starring functionality after moving the StarDashboard button to a different component.
  • Possibly tweak the magic numbers used for control bar rows. This was very difficult to get right, so I think it may be off somehow.

Screenshots

Before:
before-1

After:
after-1

Before:
before-2

After:
after-2

Before:
before-3

After:
after-3

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Sep 25, 2024

🚀 Deployed on https://pr-3095.dashboard.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify September 25, 2024 11:14 Inactive
@jenniferarnesen
Copy link
Collaborator

@cooper-joe I fixed a bunch of merge conflicts that came up after merging Mozafar's rtl PR. You might want to do a check of the affected css files:

Content.module.css
DashboardsBar.module.css
DragHandle.module.css
ShowMoreButton.module.css
DashboardContainer.module.css
FilterBadge.module.css
FilterBar.module.css
ActionsBar.module.css
Description.module.css
LastUpdatedTag.module.css
StarDashboardButton.module.css
TitleBar.module.css

@dhis2-bot dhis2-bot temporarily deployed to netlify September 26, 2024 14:11 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify September 27, 2024 06:57 Inactive
@cooper-joe cooper-joe added the on hold Do not review or merge yet label Sep 27, 2024
@janhenrikoverland janhenrikoverland marked this pull request as draft September 27, 2024 10:52
@jenniferarnesen jenniferarnesen removed the on hold Do not review or merge yet label Dec 4, 2024
@jenniferarnesen
Copy link
Collaborator

There is a new design coming in PR #3156 that renders this PR obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants