chore: stop fetching schemas and replace d2 with dataEngine #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3056--dhis2-dashboard.netlify.app |
…board-app into chore/remove-unneeded-schemas
jenniferarnesen
changed the title
jenniferarnesen
added
the
e2e record
dashboards-app
|
||||||||||||||||||||||||||||
| Project |
dashboards-app
|
| Branch Review |
chore/remove-unneeded-schemas
|
| Run status |
|
| Run duration | 02m 07s |
| Commit |
|
| Committer | Jan Henrik Øverland |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
22
|
| View all changes introduced in this branch ↗︎ | |
jenniferarnesen
approved these changes
Aug 23, 2024
dhis2-bot
added a commit
that referenced
this pull request
Aug 26, 2024
## [100.2.4](v100.2.3...v100.2.4) (2024-08-26) ### Bug Fixes * add missing dependencies for semantic-release ([#3062](#3062)) ([9fe6ae5](9fe6ae5)) * display correct app version in dhis2 and updated workflows ([#3061](#3061)) ([69b8425](69b8425)) * stop fetching schemas and replace d2 with dataEngine ([#3056](#3056)) ([49428c6](49428c6))
|
🎉 This PR is included in version 100.2.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schemas aren't needed anymore.
Also, replaced d2 with dataEngine:
We have to unfortunately disable some checks in the dashboard filter tests because cypress seems to be having a fit about the iframes. You could argue that the tests shouldn't be testing the content of the plugins anyway since we don't have control over which versions of the plugins are installed. The plugins should be getting tested in their respective apps. Still, it is sad to have to disable the checks.