-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: merge to master #3008
Merged
Merged
fix: merge to master #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
edoardo
commented
Jun 14, 2024
•
edited
Loading
edited
- fetch visualization always when caching (DHIS2-17509) fix: fetch visualization always when caching (DHIS2-17509) #2986
- use rich text component from analytics refactor: use rich text component from analytics #2474
Automatically merged.
Automatically merged.
…in Cypress Cloud (#2984) Implements DHIS2-17377 Conditional Recording Triggers: Implemented conditional recording triggers via commit messages and GitHub labels to ensure that Cypress tests are only recorded when necessary. Parallel Execution Strategies: Refined parallel execution strategies to improve efficiency and resolve test redundancies in GitHub Actions. Debugging Enhancements: Added detailed debugging outputs to help track the dynamic values of the test environment variables and ensure correct parameter passing in the workflow. Manual Grouping of Tests: In GitHub Actions, without specified test groups, all tests would run in every parallel container, leading to unnecessary repetition. By organizing tests into predefined groups, each group runs only once. This prevents redundancy and expedites the testing process. Why Not Rely on Cypress's Automatic Balancing? While Cypress automatically assigns tests to machines to balance workload (more on Cypress load balancing), GitHub Actions requires explicit distribution of tasks. This manual grouping ensures efficient resource usage and prevents multiple executions of the same tests across different runners. Benefits: This approach allows precise control over test distribution, enhancing predictability and efficiency. It reduces total execution time and operational costs by ensuring each test is run precisely once across the available infrastructure. This method optimises our use of GitHub Actions, ensuring a faster, cost-effective, and efficient testing process. Update Documentation: Updated the documentation to reflect the changes and ensure clarity on the new CI/CD processes. Expected Outcomes: Reduced Cypress Cloud Credit Usage: By optimising the conditions under which tests are recorded and uploaded to Cypress Cloud, we anticipate a significant reduction in credit usage. Increased CI Efficiency: With better management of parallel execution and conditional testing, the CI process should be more efficient, leading to quicker test cycles. --------- Co-authored-by: @dhis2-bot <[email protected]> Co-authored-by: Jen Jones Arnesen <[email protected]>
* chore: run release step on tags so it publishes to d2-ci * chore: do not run release step on dev branch
A previous fix for an item flashing issue caused the offline cache to lack the request for the visualizations. The fix looks at the recording state and triggers a fetch that can be recorded.
Automatically merged.
🚀 Deployed on https://pr-3008--dhis2-dashboard.netlify.app |
jenniferarnesen
approved these changes
Jun 17, 2024
🎉 This PR is included in version 100.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.