Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch repetition data for LL to show in plugin v38 #2947

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Apr 9, 2024

Backport of #2271 .
(cherry picked from commit 25378ce)

Key features

  1. fetch repetition data for LL

Description

If a repeatable event was saved in a LL AO, it didn't show up in the plugin on dashboard.
The reason was because dashboard didn't fetch the repetition data with the rest of the fields passed to the plugin.


Screenshots

Before:
Screenshot 2023-03-22 at 14 56 54

After:
Screenshot 2023-03-23 at 10 59 11

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Apr 9, 2024

🚀 Deployed on https://pr-2947--dhis2-dashboard.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify April 9, 2024 09:41 Inactive
Copy link

cypress bot commented Apr 9, 2024

Passing run #4695 ↗︎

0 59 0 0 Flakiness 0

Details:

Merge branch 'v38' into backport/repetitions-in-ll-plugin-v38
Project: dashboards-app Commit: bac9f6a713
Status: Passed Duration: 04:45 💡
Started: Apr 9, 2024 11:15 AM Ended: Apr 9, 2024 11:20 AM

Review all test suite changes for PR #2947 ↗︎

@dhis2-bot dhis2-bot temporarily deployed to netlify April 9, 2024 11:13 Inactive
@edoardo edoardo merged commit 10aea7d into v38 Apr 9, 2024
11 checks passed
@edoardo edoardo deleted the backport/repetitions-in-ll-plugin-v38 branch April 9, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants