Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable flaky test #2940

Merged
merged 1 commit into from
Mar 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions cypress/integration/edit/edit_dashboard.feature
Original file line number Diff line number Diff line change
@@ -55,15 +55,15 @@ Feature: Creating, editing and deleting dashboard
Then the dashboard is not starred


@mutating
Scenario: I toggle show description
Given I open existing dashboard
# And the description is not shown
And the dashboard description is not displayed
When I click to show description
Then the dashboard description is displayed
When I click to hide the description
Then the dashboard description is not displayed
# @mutating
# Scenario: I toggle show description
# Given I open existing dashboard
# # And the description is not shown
# And the dashboard description is not displayed
# When I click to show description
# Then the dashboard description is displayed
# When I click to hide the description
# Then the dashboard description is not displayed

# FIXME
# @nonmutating

Unchanged files with check annotations Beta

'--headerbar-height',
`${headerbarHeight}px`
)
}, [])

Check warning on line 46 in src/components/App.js

GitHub Actions / lint

React Hook useEffect has a missing dependency: 'props'. Either include it or remove the dependency array. However, 'props' will change when *any* prop changes, so the preferred fix is to destructure the 'props' object outside of the useEffect call and refer to those specific props inside useEffect
return (
systemSettings && (
updateUserRows(Math.min(newRows, MAX_ROW_COUNT))
userRowsChanged.current = true
}
}, [mouseYPos])

Check warning on line 56 in src/components/DashboardsBar/DashboardsBar.js

GitHub Actions / lint

React Hook useEffect has missing dependencies: 'onExpandedChanged', 'updateUserRows', and 'userRows'. Either include them or remove the dependency array. If 'onExpandedChanged' changes too often, find the parent component that defines it and wrap that definition in useCallback
useEffect(() => {
rootElement.style.setProperty('--user-rows-count', userRows)
}, [userRows])

Check warning on line 60 in src/components/DashboardsBar/DashboardsBar.js

GitHub Actions / lint

React Hook useEffect has a missing dependency: 'rootElement.style'. Either include it or remove the dependency array
useEffect(() => {
const vh = height * 0.01
rootElement.style.setProperty('--vh', `${vh}px`)
}, [height])

Check warning on line 65 in src/components/DashboardsBar/DashboardsBar.js

GitHub Actions / lint

React Hook useEffect has a missing dependency: 'rootElement.style'. Either include it or remove the dependency array
useEffect(() => {
if (!dragging && userRowsChanged.current) {
apiPostControlBarRows(userRows)
userRowsChanged.current = false
}
}, [dragging, userRowsChanged.current])

Check warning on line 72 in src/components/DashboardsBar/DashboardsBar.js

GitHub Actions / lint

React Hook useEffect has a missing dependency: 'userRows'. Either include it or remove the dependency array. Mutable values like 'userRowsChanged.current' aren't valid dependencies because mutating them doesn't re-render the component
const scrollToTop = () => {
if (expanded) {
scrollToTop()
onExpandedChanged(!expanded)
}
}, [expanded])

Check warning on line 87 in src/components/DashboardsBar/DashboardsBar.js

GitHub Actions / lint

React Hook useCallback has missing dependencies: 'memoizedCancelExpanded', 'onExpandedChanged', and 'scrollToTop'. Either include them or remove the dependency array. If 'onExpandedChanged' changes too often, find the parent component that defines it and wrap that definition in useCallback
const memoizedCancelExpanded = useCallback(() => {
scrollToTop()
onExpandedChanged(false)
}, [])

Check warning on line 92 in src/components/DashboardsBar/DashboardsBar.js

GitHub Actions / lint

React Hook useCallback has missing dependencies: 'onExpandedChanged' and 'scrollToTop'. Either include them or remove the dependency array. If 'onExpandedChanged' changes too often, find the parent component that defines it and wrap that definition in useCallback
return (
<div
)
}
fetchData()
}, [])

Check warning on line 39 in src/components/SystemSettingsProvider.js

GitHub Actions / lint

React Hook useEffect has a missing dependency: 'engine'. Either include it or remove the dependency array
return (
<SystemSettingsCtx.Provider
})
}
fetchData()
}, [])

Check warning on line 24 in src/components/UserSettingsProvider.js

GitHub Actions / lint

React Hook useEffect has a missing dependency: 'engine'. Either include it or remove the dependency array
return (
<UserSettingsCtx.Provider
) {
fetchDimensions()
}
}, [dimensions, doFetch, userSettings.keyAnalysisDisplayProperty])

Check warning on line 38 in src/modules/useDimensions.js

GitHub Actions / lint

React Hook useEffect has missing dependencies: 'dataEngine' and 'dispatch'. Either include them or remove the dependency array
return dimensions
}