Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable the e2e tests since v36 is no longer supported [v36] #2791

Merged
merged 2 commits into from
Oct 24, 2023
Merged

chore: disable the e2e tests since v36 is no longer supported [v36] #2791

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecad667
chore: disable the e2e tests since v36 is no longer supported
jenniferarnesen Oct 16, 2023
38806ba
chore: improve comment
jenniferarnesen Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/verify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,11 @@ jobs:
- name: Test
run: yarn test

# v36 is no longer supported, so set the if condition to false to skip this job
e2e:
runs-on: ubuntu-latest
needs: install
if: "!contains(github.event.head_commit.message, '[skip ci]')"
if: false

strategy:
matrix:
Expand Down Expand Up @@ -152,7 +153,7 @@ jobs:

publish:
runs-on: ubuntu-latest
needs: [build, lint, test, e2e]
needs: [build, lint, test]
if: "!contains(github.event.head_commit.message, '[skip ci]')"
steps:
- uses: actions/checkout@v2
Expand Down
Loading