fix: avoid re-rendering an item when adding the same again (DHIS2-17016)

This also avoids an unnecessary fetch of the same visualization object.
dhis2 · Mar 13, 2024 · 9b28b41 · 9b28b41
1 parent 44cd380
commit 9b28b41
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/components/Item/VisualizationItem/Item.js b/src/components/Item/VisualizationItem/Item.js
@@ -81,9 +81,13 @@ class Item extends Component {
     }
 
     async componentDidMount() {
-        this.props.setVisualization(
-            await apiFetchVisualization(this.props.item)
-        )
+        // Avoid refetching the visualization already in the Redux store
+        // when the same dashboard item is added again.
+        // This also solves a flashing of all the "duplicated" dashboard items.
+        !this.props.visualization.id &&
+            this.props.setVisualization(
+                await apiFetchVisualization(this.props.item)
+            )
 
         try {
             if (