Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [DHIS2-18582] Data element with number option set are not displayed in Stages and Events widget #3928

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: [DHIS2-18582] Data element with number option set are not displayed in Stages and Events widget #3928

wants to merge 6 commits into from

Conversation

henrikmv
Copy link
Contributor

@henrikmv henrikmv commented Jan 4, 2025 •
edited
Loading

DHIS2-18582:

  • Implements useClientDataElements hook to convert data elements to client value by formatting options based on type.
  • Returns options as an array

@henrikmv henrikmv changed the title fix: [DHIS2-18582] Data element or TEA with number option set are not displayed in stages & event widget and profile widget fix: [DHIS2-18582] Data element or TEA with number option set are not displayed in Stages and Events widget and Profile widget Jan 4, 2025
@henrikmv henrikmv changed the title fix: [DHIS2-18582] Data element or TEA with number option set are not displayed in Stages and Events widget and Profile widget fix: [DHIS2-18582] Data element with number option set are not displayed in Stages and Events widget and Profile widget Jan 15, 2025
@henrikmv henrikmv changed the title fix: [DHIS2-18582] Data element with number option set are not displayed in Stages and Events widget and Profile widget fix: [DHIS2-18582] Data element with number option set are not displayed in Stages and Events widget Jan 16, 2025
@henrikmv henrikmv marked this pull request as ready for review January 16, 2025 10:56
@henrikmv henrikmv requested a review from a team as a code owner January 16, 2025 10:56
@henrikmv henrikmv added e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud testing labels Jan 16, 2025
@github-actions GitHub Actions
Copy link

🚀 Deployed on https://deploy-preview-3928.capture.netlify.dhis2.org

@henrikmv henrikmv removed the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Jan 21, 2025
simonadomnisoru
simonadomnisoru approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🥳

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

geethaalwan
geethaalwan approved these changes Jan 27, 2025
View reviewed changes
Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42,2.41.4,2.40.7,2.39.9 versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geethaalwan geethaalwan geethaalwan approved these changes

@simonadomnisoru simonadomnisoru simonadomnisoru approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henrikmv @simonadomnisoru @geethaalwan