fix: [DHIS2-18238] incorrect criteria when saving list with follow up false #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,7 +55,7 @@ export const addTEITemplateEpic = (action$: InputObservable, store: ReduxStore, | |||
| ...(assignedUserMode && { assignedUserMode }), | |||
| ...(assignedUsers?.length > 0 && { assignedUsers }), | |||
| ...(programStatus && { enrollmentStatus: programStatus }), | |||
| ...(!!followUp && { followUp }), | |||
| ...(followUp !== undefined && { followUp: JSON.stringify(followUp) }), | |||
There was a problem hiding this comment.
I'm very glad you know this logic better than me! Good catch 😄
simonadomnisoru
approved these changes
Oct 30, 2024
|
🚀 Deployed on https://deploy-preview-3868.capture.netlify.dhis2.org |
geethaalwan
approved these changes
Oct 31, 2024
eirikhaugstulen
deleted the
eh/fix/DHIS2-18238-incorrect-data-for-working-list
branch
|
🎉 This PR is included in version 101.14.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When creating a list with followUp explicitly marked as
false, this got filtered out before it was sent to the API.I also took the opportunity to add some ButtonStrips when already editing these files. I think it makes the UI look a bit cleaner.