feat: support custom background color #3814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirikhaugstulen
commented
Sep 26, 2024
| @@ -10,6 +10,7 @@ import { DefaultPageTitle, EnrollmentPageKeys } from './DefaultEnrollmentLayout. | |||
|
|
|||
| const getEnrollmentPageStyles = () => ({ | |||
| container: { | |||
| minHeight: '90vh', | |||
There was a problem hiding this comment.
Open for ideas on this. The page only took up the size of the widgets, but that might not have been the full size. Also, App-platform adds a small padding at the bottom, so setting it to 90 instead of 100 means it will work as corrected.
There was a problem hiding this comment.
Seems to work and I don't have a better suggestion.
JoakimSM
approved these changes
Sep 26, 2024
| @@ -10,6 +10,7 @@ import { DefaultPageTitle, EnrollmentPageKeys } from './DefaultEnrollmentLayout. | |||
|
|
|||
| const getEnrollmentPageStyles = () => ({ | |||
| container: { | |||
| minHeight: '90vh', | |||
There was a problem hiding this comment.
Seems to work and I don't have a better suggestion.
dhis2-bot
added a commit
that referenced
this pull request
Sep 27, 2024
# [101.6.0](v101.5.0...v101.6.0) (2024-09-27) ### Features * support custom background color ([#3814](#3814)) ([22cfe58](22cfe58))
|
🎉 This PR is included in version 101.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tech-summary:
#followed by 6 characters