fix: [DHIS2-17651] enrollment dashboard UI changes #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonadomnisoru
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
The UI changes look great @cooper-joe 👏 !
I fixed the cypress tests related to the selectors you modified. No need to worry about the one still failing because it's unrelated to this PR and will be fixed once is #3768 merged.
…ment-dashboard-design # Conflicts: # i18n/en.pot # src/core_modules/capture-core/components/WidgetStagesAndEvents/Stages/Stage/Stage.component.js # src/core_modules/capture-core/components/WidgetStagesAndEvents/Stages/Stage/StageDetail/StageDetail.component.js
eirikhaugstulen
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Hey @cooper-joe! I decided to merge my branch, so I took care of the merge conflicts from master. I could not see any difference in the UI, but please take a look to make sure everything is as you designed it to be before moving it to testing!
|
🚀 Deployed on https://deploy-preview-3767--dhis2-capture.netlify.app |
geethaalwan
approved these changes
Aug 28, 2024
dhis2-bot
added a commit
that referenced
this pull request
Aug 29, 2024
## [101.3.1](v101.3.0...v101.3.1) (2024-08-29) ### Bug Fixes * [DHIS2-17651] enrollment dashboard UI changes ([#3767](#3767)) ([012b60d](012b60d))
|
🎉 This PR is included in version 101.3.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements design changes to Stages and Events widget based on design review carried out for DHIS2-17651.
Summary:
DataTableToolbarfor action buttonsThese changes were approved by product manager 19/08/24 (Mike).
I notice this may clash with the work done in #3751, so let me know how you'd like to proceed @eirikhaugstulen.
Before:
After:
