feat: [DHIS2-17874] Replace the SnackBar MenuList MenuItem Grow and remaining Icons #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…https://github.com/dhis2/capture-app into hv/feat/DHIS2-17874_ReplaceSnackBarMenuListGrowIcons
…_ReplaceSnackBarMenuListGrowIcons
…/feat/DHIS2-17874_ReplaceSnackBarMenuListGrowIcons
henrikmv
added
the
e2e record
henrikmv
added
e2e-tests
e2e record
There was a problem hiding this comment.
Hi @henrikmv
Great idea to use DropdownButton and simplify the code 👏 ! Aside from the comments/questions I added, there are only a few places left where Material-UI components are still used:
- MenuItem in SearchSuggestion.component.js
- Paper in IncompleteSelectionsMessage/index.js
- IconButton in ViewEventSection and Relationships
Can you also migrate these last ones as well? Thank you!
src/core_modules/capture-core/components/FeedbackBar/FeedbackBar.component.js
Outdated
Show resolved
Hide resolved
...odules/capture-core/components/ListView/Filters/FilterButton/ActiveFilterButton.component.js
Outdated
Show resolved
Hide resolved
…_ReplaceSnackBarMenuListGrowIcons
…https://github.com/dhis2/capture-app into hv/feat/DHIS2-17874_ReplaceSnackBarMenuListGrowIcons
…https://github.com/dhis2/capture-app into hv/feat/DHIS2-17874_ReplaceSnackBarMenuListGrowIcons
…https://github.com/dhis2/capture-app into hv/feat/DHIS2-17874_ReplaceSnackBarMenuListGrowIcons
…https://github.com/dhis2/capture-app into hv/feat/DHIS2-17874_ReplaceSnackBarMenuListGrowIcons
…https://github.com/dhis2/capture-app into hv/feat/DHIS2-17874_ReplaceSnackBarMenuListGrowIcons
…https://github.com/dhis2/capture-app into hv/feat/DHIS2-17874_ReplaceSnackBarMenuListGrowIcons
henrikmv
deleted the
hv/feat/DHIS2-17874_ReplaceSnackBarMenuListGrowIcons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DHIS2-17874
Removes MUI components:
SnackBar,MenuList,MenuItem,Grow,IconButton,Paper.Removes MUI
IconsUses the dhis2/ui
DropdownButtonto simplify the code.Implements style changes to filter buttons to match the chevron in dhis2/ui
DropdownButton