Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [DHIS2-17352] Changing program in event workspace does nothing #3754

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix: [DHIS2-17352] Changing program in event workspace does nothing #3754

merged 1 commit into from
Aug 13, 2024

Conversation

eirikhaugstulen
Copy link
Contributor

Summary:

  • If you're in the EnrollmentAddEvent or EnrollmentEditEvent page, changing the program does nothing
  • Hide the program selector menu if no onSetProgramId-callback is passed in to the program selector

@eirikhaugstulen eirikhaugstulen marked this pull request as ready for review August 11, 2024 17:55
@eirikhaugstulen eirikhaugstulen requested a review from a team as a code owner August 11, 2024 17:55
@github-actions GitHub Actions
Copy link

🚀 Deployed on https://deploy-preview-3754--dhis2-capture.netlify.app

geethaalwan
geethaalwan approved these changes Aug 13, 2024
View reviewed changes
Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42,2.41.1,2.40.5,2.39.7 versions

@eirikhaugstulen eirikhaugstulen merged commit c3ce444 into master Aug 13, 2024
44 checks passed
@eirikhaugstulen eirikhaugstulen deleted the eh/fix/DHIS2-17352-disable-program-menu-on-event-workspace-pages branch August 13, 2024 15:00
dhis2-bot added a commit that referenced this pull request Aug 13, 2024
@dhis2-bot
chore(release): cut 100.77.0 [skip release]
229c79e 
# [100.77.0](v100.76.1...v100.77.0) (2024-08-13)

### Bug Fixes

* [DHIS2-17352] Changing program in event workspace does nothing ([#3754](#3754)) ([c3ce444](c3ce444))

### Features

* [DHIS2-12288] add enrollment section description ([#3750](#3750)) ([1b4be20](1b4be20))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.77.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geethaalwan geethaalwan geethaalwan approved these changes

@simonadomnisoru simonadomnisoru simonadomnisoru approved these changes

Assignees
No one assigned
Labels
released testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eirikhaugstulen @dhis2-bot @simonadomnisoru @geethaalwan