fix: [DHIS2-17632][DHIS2-17633] restrict invalid category combo for orgUnit #3738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey @eirikhaugstulen
Looks really good overall 😄 ! I just added some suggestions for renaming some variables. Besides this, is it possible to add some cypress tests for this feature?
Thank you
src/core_modules/capture-core/hooks/useCategoryComboIsValidForOrgUnit.js
Outdated
Show resolved
Hide resolved
src/core_modules/capture-core/components/Pages/MainPage/MainPage.constants.js
Show resolved
Hide resolved
|
🚀 Deployed on https://deploy-preview-3738--dhis2-capture.netlify.app |
|
Looks good from a functional perspective! Couple of nitpicky comments: |
…/DHIS2-17663-restrict-invalid-category-combo
|
Thanks for the review both of you! Should have fixed all namings and comments now 👍 |
simonadomnisoru
approved these changes
Aug 8, 2024
geethaalwan
approved these changes
Aug 9, 2024
eirikhaugstulen
deleted the
eh/fix/DHIS2-17663-restrict-invalid-category-combo
branch
dhis2-bot
added a commit
that referenced
this pull request
Aug 9, 2024
## [100.76.1](v100.76.0...v100.76.1) (2024-08-09) ### Bug Fixes * [DHIS2-17632][DHIS2-17633] restrict invalid category combo for orgUnit ([#3738](#3738)) ([bfffe06](bfffe06))
|
🎉 This PR is included in version 100.76.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tech-summary: