Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [DHIS2-17770] Org unit contextualization in self contained widgets #3720
feat: [DHIS2-17770] Org unit contextualization in self contained widgets #3720
Changes from 2 commits
25a3c5a
07f80b0
3dde56b
c201f96
0f0f3c8
4cd6a58
13eb68d
06ef38f
d453275
efbd81d
8be30ca
039c1ac
763b495
57db7da
2b43005
940f45c
712d78b
5b671b8
dc7ce33
57eab52
fbf8410
d788114
d6c8a91
707e1a9
0ff202f
b7a18ff
a66b0a2
b7f1a36
b1d1c06
6f132f0
deb46b5
8af08ee
5f9e2a6
8cc389a
649107f
9c3d38e
4a598ee
c1e0f57
9622a4b
1193a08
efe949d
8477c66
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to keep the
orgUnitName
as part of the translatable string? In other languages, the order of the words can be different than in English. One suggestion is to pass an optional prop toTooltipOrgUnit
and to display it instead of{orgUnitName}
. Something like this:// inside TooltipOrgUnit.component.js
This change will apply the dotted line to the whole label. WYDT? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked to Henrik about this one. I agree it's important to be conscious about this problem, but in this case I suggest we simplify as you could really think of the string as two columns ("started at" and then the org unit name).
EDIT: Let's add a colon to be 100% sure (Started at: Ngelehun CHC)