Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [DHIS2-17652] Replace Material-UI Avatar #3719

Merged
merged 8 commits into from
Aug 11, 2024
Merged

refactor: [DHIS2-17652] Replace Material-UI Avatar #3719

merged 8 commits into from
Aug 11, 2024

Conversation

henrikmv
Copy link
Contributor

@henrikmv henrikmv commented Jul 18, 2024 •
edited
Loading

DHIS2-17652

  • The UserAvatar component from the DHIS2 UI library is processing the image URL so it gets invalid in this case. Due to the simplicity of the component, it was made a new component adjusted to the use case, instead of making a function to get the URL right.

@henrikmv henrikmv marked this pull request as ready for review July 30, 2024 14:19
@henrikmv henrikmv requested a review from a team as a code owner July 30, 2024 14:19
@henrikmv henrikmv requested review from eirikhaugstulen and removed request for eirikhaugstulen July 30, 2024 14:19
@henrikmv henrikmv requested a review from simonadomnisoru July 31, 2024 08:48
@github-actions GitHub Actions
Copy link

🚀 Deployed on https://deploy-preview-3719--dhis2-capture.netlify.app

@henrikmv henrikmv requested a review from simonadomnisoru July 31, 2024 09:32
geethaalwan
geethaalwan approved these changes Aug 9, 2024
View reviewed changes
Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42 version

@henrikmv henrikmv merged commit e6f2a15 into master Aug 11, 2024
43 checks passed
@henrikmv henrikmv deleted the hv/feat/DHIS2-17652_ReplaceMaterialUIAvatar branch August 11, 2024 10:56
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.77.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geethaalwan geethaalwan geethaalwan approved these changes

@simonadomnisoru simonadomnisoru simonadomnisoru approved these changes

Assignees
No one assigned
Labels
e2e-tests released testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@henrikmv @dhis2-bot @simonadomnisoru @geethaalwan