fix: [DHIS2-15920] skip duplicates reviews

[simonadomnisoru]

DHIS2-15920

Tech summary

• skip the duplicates check when no attributes values were filled in

[eirikhaugstulen]

Looks good and works as expected! 🎉
However, before you merge; are we sure we want to be able to register TEIs with no attributes at all? It seems like it could potentially create a lot of duplicates that would be hard to track? (It's definitively an implementation error if it is though, just curious.)

[github-actions]

🚀 Deployed on https://deploy-preview-3629--dhis2-capture.netlify.app

[simonadomnisoru]

Looks good and works as expected! 🎉
However, before you merge; are we sure we want to be able to register TEIs with no attributes at all? It seems like it could potentially create a lot of duplicates that would be hard to track? (It's definitively an implementation error if it is though, just curious.)

Hey @eirikhaugstulen,
Currently, it is already possible to register a TEI without attributes. This PR only removes the call to check for duplicates because all the TEIs in the program are returned and the request performance is poor.
IMHO it is up to the system admin to correctly configure the required attributes if any. Perhaps @karolinelien knows some implementation use-cases where enrolling a TEI without attributes is the desired behavior.

[geethaalwan]

Tested successfully on 2.42,2.41.1,2.40.4,2.39.6,2.38.7 versions

[dhis2-bot]

🎉 This PR is included in version 100.68.14 🎉

The release is available on:

• AppHub release
• v100.68.14
• GitHub release

Your semantic-release bot 📦🚀