Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [DHIS2-17177] Registration page stuck after failed save #3595

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix: [DHIS2-17177] Registration page stuck after failed save #3595

merged 1 commit into from
Apr 29, 2024

Conversation

eirikhaugstulen
Copy link
Contributor

Tech-summary:

  • Remove uid from the redux store after a failed save attempt (this resets the loading states)

@eirikhaugstulen eirikhaugstulen requested a review from a team as a code owner April 3, 2024 14:06
simonadomnisoru
simonadomnisoru approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JoakimSM JoakimSM added testing and removed testing labels Apr 11, 2024
@github-actions GitHub Actions
Copy link

🚀 Deployed on https://deploy-preview-3595--dhis2-capture.netlify.app

geethaalwan
geethaalwan approved these changes Apr 12, 2024
View reviewed changes
Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42,2.41.0,2.40.4,2.3.6,2.38.7 versions

@JoakimSM JoakimSM merged commit 83e0399 into master Apr 29, 2024
52 checks passed
@JoakimSM JoakimSM deleted the eh/fix/DHIS2-17177-registration-page-stuck-on-failed-save branch April 29, 2024 14:59
dhis2-bot added a commit that referenced this pull request Apr 29, 2024
@dhis2-bot
chore(release): cut 100.68.3 [skip release]
1041107 
## [100.68.3](v100.68.2...v100.68.3) (2024-04-29)

### Bug Fixes

* [DHIS2-16931] Working list hides delete button ([#3603](#3603)) ([21d9d6e](21d9d6e))
* [DHIS2-17044] missing singular translation ([#3598](#3598)) ([9a7261c](9a7261c))
* [DHIS2-17096] show/hide option groups in profile widget ([#3593](#3593)) ([8aa8695](8aa8695))
* [DHIS2-17161] Do not update attribute values from enrollment Widget ([#3601](#3601)) ([7750761](7750761))
* [DHIS2-17177] Registration page stuck after failed save ([#3595](#3595)) ([83e0399](83e0399))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.68.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geethaalwan geethaalwan geethaalwan approved these changes

@JoakimSM JoakimSM JoakimSM approved these changes

@simonadomnisoru simonadomnisoru simonadomnisoru approved these changes

Assignees
No one assigned
Labels
awaiting RCB approval RCB approved released testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eirikhaugstulen @dhis2-bot @simonadomnisoru @JoakimSM @geethaalwan