fix: [DHIS2-14938] trigger error on complete #3594
Conversation
| @@ -235,7 +235,7 @@ const getSaveHandler = ( | |||
| } = this.props; | |||
|
|
|||
| const filteredProps = onFilterProps ? onFilterProps(passOnProps) : passOnProps; | |||
| this.isCompleting = !!(onIsCompleting && onIsCompleting(this.props)); | |||
| this.isCompleting = Boolean(onIsCompleting && onIsCompleting(this.props) === 'true'); | |||
There was a problem hiding this comment.
Can we change the edit event code instead of the generic withSaveHandler component? here:
I think it makes sense to keep the return value of onIsCompleting a boolean value.
| filter((action) => { | ||
| const { | ||
| meta: { triggerAction }, | ||
| } = action; | ||
| return ( | ||
| triggerAction === enrollmentSiteActionTypes.COMMIT_ENROLLMENT_EVENT || | ||
| triggerAction === enrollmentEditEventActionTypes.EVENT_SAVE_ENROLLMENT_COMPLETE_SUCCESS | ||
| ); | ||
| }), |
There was a problem hiding this comment.
Is this really needed? Seems like we return EMPTY on line 183. Is it good enough to do one or the other?
There was a problem hiding this comment.
On my localhoast, the return EMPTY statement is causing an error and the page is no longer responding when editing a single event. I remove it and filter by triggerAction instead. This is not an issue in play so should I just rollback the change and leave it as it is? 🤔
Thanks!
There was a problem hiding this comment.
I think the reason EMPTY crashes the app is that it counts as an observable and not an action; so it works as return value for switchMap but not for map. I think using filter is the best solution here. I approve the last commit 👍
There was a problem hiding this comment.
I see, thanks. Current PR looks good to me.
|
🚀 Deployed on https://deploy-preview-3594--dhis2-capture.netlify.app |
|
🎉 This PR is included in version 100.67.12 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
DHIS2-14938
Tech summary:
The
completeDataEntryFieldValueprop can take different values (i.e.,undefined,null,'true','false'). The values come from the redux store keydataEntriesFieldsValuewhich is initialized and handled differently by different forms. I fixed the edit event code to return the value ofonIsCompletinga boolean value.