fix: [DHIS2-17102] edit event navigation #3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superskip
reviewed
Apr 8, 2024
| if (eventContainer.event && eventContainer.event.attributeCategoryOptions) { | ||
| eventContainer.event.attributeCategoryOptions = | ||
| convertCategoryOptionsToServer(eventContainer.event.attributeCategoryOptions); | ||
| } | ||
| let actions = [updateEventContainer(eventContainer, orgUnit)]; | ||
| let actions = []; | ||
|
|
||
| if (meta.triggerAction === enrollmentSiteActionTypes.ROLLBACK_ENROLLMENT_EVENT) { | ||
| actions = [...actions, rollbackEnrollmentEvent(eventContainer.event.eventId)]; | ||
| } | ||
| if (meta.triggerAction === enrollmentEditEventActionTypes.EVENT_SAVE_ENROLLMENT_COMPLETE_ERROR) { |
There was a problem hiding this comment.
This can be changed into else if, which in turn let us avoid using spread syntax on actions.
There was a problem hiding this comment.
I removed the unnecessary spread syntax on actions. Thanks for the feedback!
There was a problem hiding this comment.
It is more efficient to use else if as well here (because then the second condition will not get evaluated whenever the first one evaluates to true)
There was a problem hiding this comment.
Good point! The code should be updated now. Thanks!
|
🚀 Deployed on https://deploy-preview-3592--dhis2-capture.netlify.app |
geethaalwan
approved these changes
Apr 17, 2024
|
🎉 This PR is included in version 100.68.14 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DHIS2-17102
Tech summary: