Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DHIS2-16745] dynamic naming to relationship widget #3528

Merged
merged 1 commit into from
Feb 8, 2024
Merged

feat: [DHIS2-16745] dynamic naming to relationship widget #3528

merged 1 commit into from
Feb 8, 2024

Conversation

eirikhaugstulen
Copy link
Contributor

TECH-summary:

  • Passed down trackedEntityTypeName to the Breadcrumbs-component
  • Used this to display dynamic title

@eirikhaugstulen eirikhaugstulen marked this pull request as ready for review February 7, 2024 10:59
@eirikhaugstulen eirikhaugstulen requested a review from a team as a code owner February 7, 2024 10:59
simonadomnisoru
simonadomnisoru approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

🚀 Deployed on https://deploy-preview-3528--dhis2-capture.netlify.app

geethaalwan
geethaalwan approved these changes Feb 8, 2024
View reviewed changes
Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.41,2.40.4,2.39.5,2.38.7 versions

@eirikhaugstulen eirikhaugstulen merged commit f8d52c2 into master Feb 8, 2024
37 checks passed
@eirikhaugstulen eirikhaugstulen deleted the eh/TECH/DHIS2-16745-add-dynamic-TEI-Name branch February 8, 2024 12:27
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.56.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geethaalwan geethaalwan geethaalwan approved these changes

@simonadomnisoru simonadomnisoru simonadomnisoru approved these changes

Assignees
No one assigned
Labels
released testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eirikhaugstulen @dhis2-bot @simonadomnisoru @geethaalwan