Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [DHIS2-14275] Support custom icons #3473

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

eirikhaugstulen
Copy link
Contributor

Support custom icons

TECH-summary:

  • Add feature flag for custom icons
  • Check if applicable, and add .svg suffix if v<41
  • Add tests

@eirikhaugstulen eirikhaugstulen marked this pull request as ready for review November 28, 2023 08:11
@eirikhaugstulen eirikhaugstulen requested a review from a team as a code owner November 28, 2023 08:11
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👏

Copy link

Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.41 version

@eirikhaugstulen eirikhaugstulen merged commit 2404fca into master Nov 30, 2023
36 checks passed
@eirikhaugstulen eirikhaugstulen deleted the eh/feat/DHIS2-14275-CustomIcons branch November 30, 2023 12:20
dhis2-bot added a commit that referenced this pull request Nov 30, 2023
# [100.46.0](v100.45.2...v100.46.0) (2023-11-30)

### Features

* [DHIS2-14275] Support custom icons ([#3473](#3473)) ([2404fca](2404fca))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.46.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants