Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [DHIS2-15686] fix program rule variables for edit profile mode #3463

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

superskip
Copy link
Contributor

@superskip superskip commented Nov 15, 2023

DHIS2-15686

Corrects some inaccuracies in the profile widget's rule engine payload builder.

@superskip superskip requested a review from a team as a code owner November 15, 2023 17:37
@superskip
Copy link
Contributor Author

The latest addition to useProgram.js looks kind of ugly though, doesn't it? 🤔
Do you think we should bother with trying a different approach, for instance continuing along the lines I erased from rulesContainer.js?

Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.41,2.40.3,2.39.4,2.38.6 versions

@superskip superskip merged commit a24bb27 into master Nov 30, 2023
39 checks passed
@superskip superskip deleted the DHIS2-15686 branch November 30, 2023 12:46
dhis2-bot added a commit that referenced this pull request Nov 30, 2023
## [100.46.1](v100.46.0...v100.46.1) (2023-11-30)

### Bug Fixes

* [DHIS2-15686] fix program rule variables for edit profile mode ([#3463](#3463)) ([a24bb27](a24bb27))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.46.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants