chore: [TECH-1541] Replace Material UI Dialog #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey @eirikhaugstulen,
It looks like there are a few places where the material-ui dialog components are still used. Some example:
- PolygonField.component.js
- DeleteConfirmationDialog.component.js
- ExistingTemplateContents.component.js
- ExistingTemplateDialog.component.js
- NewTemplateContents.component.js
- NewTemplateDialog.component.js
- DownloadDialog.component.js
Can you replace them too? Thank you!
|
Thanks for the review @simonadomnisoru - I had my filters set up a bit wrong, but it should be good now 👋 |
|
🚀 Deployed on https://deploy-preview-3460--dhis2-capture.netlify.app |
geethaalwan
approved these changes
Dec 7, 2023
|
🎉 This PR is included in version 100.47.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tech summary:
Replace Material-UI's Dialog with
@dhis2/ui's Modal-component.I will add DHIS2-16229 to the lists of tests to follow up on in the wiki.