Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [DHIS-15621] row is broken up in sections #3435

Closed

Conversation

henrikmv
Copy link
Contributor

No description provided.

@henrikmv henrikmv requested a review from a team as a code owner October 16, 2023 19:57
@henrikmv henrikmv changed the title feat: [DHIS-15621] row is broken up in sections fix: [DHIS-15621] row is broken up in sections Oct 16, 2023
<div>
<div
className={applyCustomFormClass ? this.props.classes.containerCustomForm : ''}
data-test="d2-form-component"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @henrikmv,
There seem to be a lot of broken cypress tests. Could it be related to the data-test="d2-form-component" selector you moved?
Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the notification @simonadomnisoru!
Pushed a temporary commit, but will continue the work until the tests are successful.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henrikmv Note that you don't need to fix all tests: you can ignore all where an orgunit name is missing (looks like there are six of them - https://cloud.cypress.io/projects/322xnh/runs/9730/overview?roarHideRunsWithDiffGroupsAndTags=1).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henrikmv We track known cypress bugs on the repository wiki. You only need to look into the failed tests that are not on that list. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonadomnisoru Hmm, it doesn't seem to quite agree with the errors I got 🤔

@JoakimSM JoakimSM marked this pull request as draft October 27, 2023 08:23
@henrikmv henrikmv closed this Nov 3, 2023
@henrikmv henrikmv force-pushed the hv/fix/DHIS2-15621_RowViewIsBrokenUpInSection branch from 1253119 to d9db7be Compare November 3, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants