Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [DHIS2-15879] Unable to schedule event with note #3421

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

eirikhaugstulen
Copy link
Contributor

TECH Summary:
The API throws an error in the current scheduling functionality, as the provided ID is not in the correct format. Therefore, I have switched to the same algorithm we use in Relationships and Referrals

@eirikhaugstulen eirikhaugstulen requested a review from a team as a code owner September 27, 2023 09:22
@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏
NIT: Add a Cypress scenario to check that the user can successfully schedule an event with a note. Thanks!

Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.41,2.40.2,2.39.4,2.38.5 versions

@eirikhaugstulen eirikhaugstulen merged commit e017ac8 into master Oct 27, 2023
35 of 36 checks passed
@eirikhaugstulen eirikhaugstulen deleted the eh/fix/UnableToScheduleEventWithNote branch October 27, 2023 09:57
dhis2-bot added a commit that referenced this pull request Oct 31, 2023
# [100.43.0](v100.42.0...v100.43.0) (2023-10-31)

### Bug Fixes

* **translations:** sync translations from transifex (master) ([9636ea1](9636ea1))
* [DHIS2-15879] Unable to schedule event with note ([#3421](#3421)) ([e017ac8](e017ac8))

### Features

* [DHIS-14012] removed download as XML button ([#3434](#3434)) ([7b0e387](7b0e387))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

simonadomnisoru pushed a commit that referenced this pull request Nov 8, 2023
# [100.43.0](v100.42.0...v100.43.0) (2023-10-31)

### Bug Fixes

* **translations:** sync translations from transifex (master) ([9636ea1](9636ea1))
* [DHIS2-15879] Unable to schedule event with note ([#3421](#3421)) ([e017ac8](e017ac8))

### Features

* [DHIS-14012] removed download as XML button ([#3434](#3434)) ([7b0e387](7b0e387))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants