-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [DHIS2-15879] Unable to schedule event with note #3421
Conversation
🚀 Deployed on https://deploy-preview-3421--dhis2-capture.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👏
NIT: Add a Cypress scenario to check that the user can successfully schedule an event with a note. Thanks!
…duleEventWithNote
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully on 2.41,2.40.2,2.39.4,2.38.5 versions
# [100.43.0](v100.42.0...v100.43.0) (2023-10-31) ### Bug Fixes * **translations:** sync translations from transifex (master) ([9636ea1](9636ea1)) * [DHIS2-15879] Unable to schedule event with note ([#3421](#3421)) ([e017ac8](e017ac8)) ### Features * [DHIS-14012] removed download as XML button ([#3434](#3434)) ([7b0e387](7b0e387))
🎉 This PR is included in version 100.43.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
# [100.43.0](v100.42.0...v100.43.0) (2023-10-31) ### Bug Fixes * **translations:** sync translations from transifex (master) ([9636ea1](9636ea1)) * [DHIS2-15879] Unable to schedule event with note ([#3421](#3421)) ([e017ac8](e017ac8)) ### Features * [DHIS-14012] removed download as XML button ([#3434](#3434)) ([7b0e387](7b0e387))
TECH Summary:
The API throws an error in the current scheduling functionality, as the provided ID is not in the correct format. Therefore, I have switched to the same algorithm we use in Relationships and Referrals