-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [DHIS2-9661][DHIS2-14830] first stage registration #3267
Conversation
Hey @simonadomnisoru, Skjermopptak.2023-06-20.kl.16.11.06.mov |
Hey @JoakimSM, code updated. Can you take a look? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Nice, good work @simonadomnisoru.
🚀 Deployed on https://deploy-preview-3267--dhis2-capture.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully on 2.41,2.40.2,2.39.3,2.38.5 versions
# [100.41.0](v100.40.1...v100.41.0) (2023-10-03) ### Features * [DHIS2-9661][DHIS2-14830] first stage on registration page ([#3267](#3267)) ([6e5f6fe](6e5f6fe))
🎉 This PR is included in version 100.41.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Co-authored-by: jasminenguyennn <[email protected]> Co-authored-by: Joakim Storløkken Melseth <[email protected]>
# [100.41.0](v100.40.1...v100.41.0) (2023-10-03) ### Features * [DHIS2-9661][DHIS2-14830] first stage on registration page ([#3267](#3267)) ([6e5f6fe](6e5f6fe))
DHIS2-9661. The PR builds on work done previously in #3217.
Tech summary
Currently, the D2Form is rendered between the TOP and BOTTOM dataEntrySections definitions. I introduced the concept of placements.BEFORE_METADATA_BASED_SECTION to be able to render the stage dataEntrySections definitions in between the concatenated enrollment metadata and the stage metadata. The getCustomContent callback implements the logic to render the
placements.BEFORE_METADATA_BASED_SECTION
dataEntrySections based onbeforeSectionId
value.useFirstStageDuringRegistration
flag is active, the hook will create a new RenderFoundation which concatenates the enrollment and first program stage metadata. The concatenated formFoundation will be used by theEnrollmentWithFirstStageDataEntry
and the program rules execution.placements.BEFORE_METADATA_BASED_SECTION
concept.foundation.featureType
but also any customFeatureType like the stageGeometryformFoundation
and use it as the base forfoundationForPostProcessing
/enrollmentEventEdit
page. When initMode is set up, this overrides any page logic on the initial load.