Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(offline): clear SWR caches betwen users [LIBS-358] #1268

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

KaiVandivier
Copy link
Contributor

Part of https://dhis2.atlassian.net/browse/LIBS-356

This PR is related to but independent of dhis2/app-platform#757

This is in case some sensitive data ends up in the SWR cache, which is intended for files to be cached at runtime, but might end up caching something .json or .action data (though those extensions are being filtered in platform PR 757 above)

@KaiVandivier KaiVandivier requested review from amcgee and a team October 18, 2022 11:54
@@ -5,7 +5,6 @@ export const SECTIONS_STORE = 'sections-store'
// Non-sensitive caches that can be kept:
const KEEPABLE_CACHES = [
/^workbox-precache/, // precached static assets
/^other-assets/, // static assets cached at runtime - shouldn't be sensitive
Copy link
Contributor Author

@KaiVandivier KaiVandivier Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is the main change. The rest are to update tests and satisfy typescript

Copy link
Member

@amcgee amcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KaiVandivier KaiVandivier force-pushed the libs-358-fix-remove-other-assets-btwn-users branch from f3915d9 to 7b5aa00 Compare October 24, 2022 13:05
@KaiVandivier KaiVandivier merged commit fc0d143 into master Oct 24, 2022
@KaiVandivier KaiVandivier deleted the libs-358-fix-remove-other-assets-btwn-users branch October 24, 2022 13:16
dhis2-bot added a commit that referenced this pull request Oct 24, 2022
## [3.6.1](v3.6.0...v3.6.1) (2022-10-24)

### Bug Fixes

* **offline:** clear SWR caches betwen users [LIBS-358] ([#1268](#1268)) ([fc0d143](fc0d143))
@dhis2-bot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants