Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change dhis/ui to a peer dependency #892

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kabaros
Copy link
Contributor

@kabaros kabaros commented Nov 7, 2024

No description provided.

@kabaros
Copy link
Contributor Author

kabaros commented Nov 7, 2024

I am unable to validate this change locally, and the best way I can think of is to merge it to alpha and try it from there.

My assumption is that clients would need to install @dhis2/ui, but I think that's ok (and that's what the majority of projects do anyhow) and it's better than having to dedupe or add a resolution every time there is an update to app-platform.

It's hard to test locally because right now, the shell is a dependency of cli-app-scripts and the UI library is a dependency of the shell. If I run a local version of init script, then it uses the published cli-app-scripts. I can change that manually to use a local version published from yalc, but then that still gets the shell from the published version. Having two levels of yalc dependencies (i.e. cli-app-scripts published through yalc, while using app-shell that's also published through yalc) doesn't quite work. If anyone has an idea of how this can be tested locally then let me know!

@kabaros kabaros force-pushed the refactor/fix-ui-peer-dep branch from 2f89dc8 to a507d1f Compare November 11, 2024 07:41
Base automatically changed from alpha to master December 13, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant