feat: auto redirect to safe mode on login app error [LIBS-670] #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT
Might be good to decide if we want to implement safe login mode in v42, before proceeding with an auto redirect as now the app on error (in v42) will redirect to a non-existent page. Also, might be good to think about what safe login mode should look like as an autoredirect will now bring users to a login page that looks different than the actual login page (which I imagine could make people suspicious of the content)
See https://dhis2.atlassian.net/jira/software/c/projects/LIBS/issues/LIBS-670
This PR: