Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prep for global shell [DHIS2-15635] #829

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Conversation

KaiVandivier
Copy link
Contributor

@KaiVandivier KaiVandivier commented Feb 15, 2024

Part of DHIS2-15635

WIP -- more features coming


  • Builds a "pluginified app" to an app.html entry point that can be hosted by a global shell
  • Hosts a dev server for the pluginified app
  • Use absolute URLs for app runtime to allow client-side routing without breaking the data service
  • Build a version of the app to index.html that includes the global shell that hosts the pluginified app.html entrypoint
  • Improve the dev experience: currently it's a slow start time that creates a minified production build that runs on a second port, and React Dev Tools aren't available in iframes by default
    • Inject a script import to enable standalone React Dev Tools in the dev build... there might be a way to do this in the plugin Webpack config
    • Using Vite could solve the dev build and server problems
    • If Vite isn't used, fixing the dev build with Webpack is important
  • Rework plugin HTML to allow height: 100% plugins
  • Remove the headerbar in most cases -- that should live in the Global Shell usually
  • Maybe hoist a few features like online status, locale, and server info from Adapter into the Global Shell
  • Add the Global Shell to this repo? 🤔

@KaiVandivier KaiVandivier changed the base branch from master to alpha November 7, 2024 16:24
Base automatically changed from alpha to master December 13, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant