Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't open browser for plugins on start [LIBS-503] #821

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

KaiVandivier
Copy link
Contributor

https://dhis2.atlassian.net/browse/LIBS-503

Plugins are generally intended to be run inside other apps and therefore require other context to run -- it doesn't make sense to open up a browser and try to run it on its own

@KaiVandivier KaiVandivier requested a review from a team December 11, 2023 12:05
@KaiVandivier KaiVandivier force-pushed the LIBS-503-no-browser-for-plugins branch from 2eb1ba4 to 37b343e Compare December 11, 2023 12:06
@KaiVandivier KaiVandivier changed the title fix: don't open browser for plugins on start fix: don't open browser for plugins on start [LIBS-503] Dec 11, 2023
@KaiVandivier KaiVandivier merged commit 7db7a69 into master Dec 11, 2023
8 checks passed
@KaiVandivier KaiVandivier deleted the LIBS-503-no-browser-for-plugins branch December 11, 2023 17:09
dhis2-bot added a commit that referenced this pull request Dec 11, 2023
## [10.3.11](v10.3.10...v10.3.11) (2023-12-11)

### Bug Fixes

* don't open browser for plugins on start [LIBS-503] ([#821](#821)) ([7db7a69](7db7a69))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 10.3.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

dhis2-bot added a commit that referenced this pull request Dec 21, 2023
# [10.4.0-alpha.6](v10.4.0-alpha.5...v10.4.0-alpha.6) (2023-12-21)

### Bug Fixes

* don't open browser for plugins on start [LIBS-503] ([#821](#821)) ([7db7a69](7db7a69))
* update alpha ([e66a8ea](e66a8ea))
* update alpha [skip release] ([ec772f6](ec772f6))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 10.4.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants