Skip to content

Commit

Permalink
chore: remove some todos
Browse files Browse the repository at this point in the history
  • Loading branch information
KaiVandivier committed Jan 13, 2025
1 parent 6faf259 commit f931544
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions examples/simple-app/src/PluginTester.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const PluginTester = () => {

return (
<div>
{/* Todo: 1. Container-driven default */}
{/* 1. Container-driven default */}
<p>
Container-driven default. Expectation: fills container width,
height = content height. A wrapper div is needed to make margins
Expand Down Expand Up @@ -55,8 +55,7 @@ const PluginTester = () => {
</p>
<Plugin pluginSource={pSrc} height="222px" width="444px" />

{/* Todo: 4. Content-driven option */}
{/* To do: error screen breaks sizing */}
{/* 4. Content-driven option */}
<p>
Content-driven size. Expectation: width is defined by content;
iframe grows and shrinks
Expand All @@ -67,8 +66,6 @@ const PluginTester = () => {
clientWidth="max-content"
/>

{/* Todo: is there a time when we would need to specify height? 🤔 */}

{/* 5. Flex horizontal */}
{/* Currently working */}
<p>
Expand All @@ -87,7 +84,7 @@ const PluginTester = () => {
<Block />
</div>

{/* Todo: 6. Flex vertical */}
{/* 6. Flex vertical */}
{/* Currently working; height is still getting set by the resize observer, but className styles are overriding them */}
<p>
Flex vertical. Expectation: iframe resizes vertically according
Expand Down

0 comments on commit f931544

Please sign in to comment.