Skip to content

Commit

Permalink
docs: remove "noticed in __ app" mentions
Browse files Browse the repository at this point in the history
  • Loading branch information
KaiVandivier committed Nov 2, 2024
1 parent c6364c3 commit 9ecce0d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions docs/migration/v12.md
Original file line number Diff line number Diff line change
Expand Up @@ -316,9 +316,9 @@ By default, Vite adds its environment variables to the [`import.meta.env` object

Here are some edge cases that were encountered when upgrading some apps with the new platform version:

- There is a bug in Vite: importing from a directory, e.g. `'./app/'` where we would assume to get `./app/index.[jt]s`, can incorrectly resolve to a file with a similar name to the directory, e.g. `./App.tsx`. I see this as a bug with Vite, but as a workaround, file and dir names can be changed so they don't conflict. Noticed in the Maintenance app beta.
- There is a bug in Vite: importing from a directory, e.g. `'./app/'` where we would assume to get `./app/index.[jt]s`, can incorrectly resolve to a file with a similar name to the directory, e.g. `./App.tsx`. I see this as a bug with Vite, but as a workaround, file and dir names can be changed so they don't conflict.
- If you're using `identity-obj-proxy` in your test config, make sure you add it to the project's dependencies. Previously, some apps got away with using the proxy without an explicitid dependency because the package is a dependency of `react-scripts`
- You may see some build warnings coming from the `mathjs` package. Upgrading to a recent version of `mathjs` will handle these warnings. Noticed in analytics app (the analytics library has a dependency on `mathjs`)
- You may see some build warnings coming from the `mathjs` package. Upgrading to a recent version of `mathjs` will handle these warnings.

## Full list of breaking changes and deprecations

Expand All @@ -337,7 +337,7 @@ The most likely and impactful breaking changes have been described in detail abo
9. An `App.jsx` entrypoint is no longer quietly added if a plugin entrypoint is defined or for a defined but empty entrypoints object
10. Plugins and apps are started together in the same process on the same port
11. Custom `index.html` files are no longer supported
12. `import * as MyClass from 'my-module'` is now more restrictive, and may break in some cases. So far, changing the import to `import MyClass from 'my-module'` has fixed it. DOMPurify is one example case, noticed in the Login App
12. `import * as MyClass from 'my-module'` is now more restrictive, and may break in some cases. So far, changing the import to `import MyClass from 'my-module'` has fixed it. DOMPurify is one example case.

### Deprecations

Expand Down

0 comments on commit 9ecce0d

Please sign in to comment.