Skip to content

Commit

Permalink
docs: update README and package.json files, remove some unused comments
Browse files Browse the repository at this point in the history
  • Loading branch information
amcgee committed Feb 19, 2019
1 parent d123a44 commit 815454d
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 10 deletions.
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
BSD 3-Clause License

Copyright (c) 2019, Austin McGee
Copyright (c) 2019, University of Oslo
All rights reserved.

Redistribution and use in source and binary forms, with or without
Expand Down
16 changes: 15 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1 +1,15 @@
# dhis2-app-platform
# dhis2-app-platform

TODO

- [x] Working POC
- [ ] Build app component bundles with WebPack (using SplitChunks for shared code)
- [ ] Support simple configuration (`d2.config.js` or `.d2rc`)
- [ ] Support specifying appShell for testing
- [ ] Support automatic clearing of `.d2/shell` when new version installed (use prepublish script?)
- [ ] Support non-js app includes (images, static files, etc.)
- [ ] Reference React from appShell instead of bundling a second local version
- [ ] Support bundle analysis
- [ ] Name bundles based on application name
- [ ] Support plugin entrypoint
- [ ] Pass server URL to application component (or provide server context)
3 changes: 2 additions & 1 deletion examples/simple/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
"name": "example-cra",
"version": "1.0.0",
"main": "index.js",
"repository": "https://github.com/amcgee/dhis2-app-platform",
"author": "Austin McGee <[email protected]>",
"license": "MIT",
"license": "BSD-3-Clause",
"private": true,
"dependencies": {

Expand Down
8 changes: 1 addition & 7 deletions packages/app-scripts/src/commands/start.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const bootstrapShell = require('../lib/bootstrapShell');
const { reporter, exec } = require('@dhis2/cli-helpers-engine');
const { reporter } = require('@dhis2/cli-helpers-engine');
const concurrently = require('concurrently');
const makePaths = require('../lib/paths');

Expand All @@ -20,12 +20,6 @@ const handler = async ({ ...argv }) => {
}], {
killOthers: ['failure', 'failure']
})
// await exec({
// cmd: 'yarn',
// args: ['run', 'start'],
// cwd: shellDir,
// pipe: true
// });
} catch (err) {
reporter.error('Start script exited with non-zero exit code');
reporter.debugErr(err);
Expand Down
3 changes: 3 additions & 0 deletions packages/app-shell/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
{
"name": "@dhis2/app-shell",
"version": "0.1.0",
"repository": "https://github.com/amcgee/dhis2-app-platform",
"author": "Austin McGee <[email protected]>",
"license": "BSD-3-Clause",
"private": true,
"dependencies": {
"@types/jest": "24.0.5",
Expand Down

0 comments on commit 815454d

Please sign in to comment.