Fix code review comments

dhis2 · Oct 13, 2022 · 5ff716c · 5ff716c
1 parent 5702a7e
commit 5ff716c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/src/main/java/org/hisp/dhis/utils/PredictableRandomizer.java b/src/main/java/org/hisp/dhis/utils/PredictableRandomizer.java
@@ -133,10 +133,15 @@ public String randomNationalId() {
     }
 
     @Override
-    public Date randomBirthday() {
+    public Date randomAdultBirthday() {
         return this.faker.date().birthday( 18, 80 );
     }
 
+    @Override
+    public Date randomBirthday(int minAge, int maxAge){
+        return this.faker.date().birthday( minAge, maxAge );
+    }
+
     @Override
     public String randomLongText( int wordCount ) {
         return this.faker.lorem().sentence( wordCount );

diff --git a/src/main/java/org/hisp/dhis/utils/Randomizer.java b/src/main/java/org/hisp/dhis/utils/Randomizer.java
@@ -45,7 +45,7 @@ default <T> T randomElementFromList( List<T> list )
     <T> List<T> randomElementsFromList(List<T> list, int size);
 
     /**
-     * Returns random string containing 6 alphabetical characters.
+     * Returns random string.
      *
      * @return a String
      */
@@ -125,7 +125,15 @@ default <T> T randomElementFromList( List<T> list )
      *
      * @return a birthday date
      */
-    Date randomBirthday();
+    Date randomAdultBirthday();
+
+    /**
+     * Generates random birthday date with age
+     * between minAge and maxAge
+     *
+     * @return a birthday date
+     */
+    Date randomBirthday(int minAge, int maxAge);
 
     /**
      * Generates random long text