Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: single value as a Highcharts instance #1698

Merged
merged 82 commits into from
Oct 22, 2024
+2,104 −1,055
Merged

feat: single value as a Highcharts instance #1698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
dee77f5
feat: single value as a highcharts instance WIP
HendrikThePendric Aug 27, 2024
f344ece
chore: resizing the container
HendrikThePendric Sep 2, 2024
ac96683
chore: scaling the icon correctly
HendrikThePendric Sep 4, 2024
ea4e16c
fix: rework old implementation WIP
HendrikThePendric Sep 4, 2024
30a1168
chore: align single value store with other highcharts charts
HendrikThePendric Sep 10, 2024
61f3cf3
chore: use noAxis for single value type
HendrikThePendric Sep 10, 2024
b110076
chore: clean up comments and console log
HendrikThePendric Sep 10, 2024
8a1dadc
chore: switch to highcharts adapter in story
HendrikThePendric Sep 11, 2024
9ccc404
feat: add generic mechanism for rendering custom SVGs on chart load e…
HendrikThePendric Sep 11, 2024
5d2ee6e
chore: produce empty series for single value
HendrikThePendric Sep 11, 2024
aca4aad
chore: return null instead of an empty object so it is cleaned later
HendrikThePendric Sep 11, 2024
568a0f1
fix: do not return a chart type for single value because it does not …
HendrikThePendric Sep 11, 2024
772640b
fix: implement subtitle and title logic for single value chart
HendrikThePendric Sep 11, 2024
b6ebe34
fix: remove yAxis from single value highcharts config
HendrikThePendric Sep 11, 2024
d9fb7b8
refactor: implement single value config via Highcharts adapter
HendrikThePendric Sep 12, 2024
31040e6
fix: set subtext in customSVGOptions
HendrikThePendric Sep 12, 2024
0ed75e9
chore: positioning WIP
HendrikThePendric Sep 17, 2024
6676a45
chore: ensure Roboto font is preloaded to prevent text size computati…
HendrikThePendric Sep 18, 2024
1e5465f
chore: position all SVG elements using Highcharts SVGElement.align()
HendrikThePendric Sep 18, 2024
fb02ca6
chore: remove files from failed initial re-implementation
HendrikThePendric Sep 18, 2024
cfdc624
chore: re-enable no-unused-vars ESLint rule and address related issues
HendrikThePendric Sep 18, 2024
d72b3c0
chore: update background to white when exporting and background is tr…
HendrikThePendric Sep 18, 2024
4bd39c6
chore: give icon the same height as value text
HendrikThePendric Sep 19, 2024
1af4cda
chore: adjust story so all scenarios can be tested
HendrikThePendric Sep 19, 2024
cf21e65
fix: prevent checkIfFitsWithinContainer throwing an error when subtex…
HendrikThePendric Sep 19, 2024
c036a9d
chore: reduce subtext size
HendrikThePendric Sep 19, 2024
179c762
fix: multiline subtitle in dashboard view
HendrikThePendric Sep 19, 2024
32dfc99
chore: adjust story styles
HendrikThePendric Sep 19, 2024
cdff51b
fix: adjust dashboard title styles to original implementation
HendrikThePendric Sep 19, 2024
645ae28
chore: remove commented variable
HendrikThePendric Sep 23, 2024
a5b0c66
feat: single value as a highcharts instance WIP
HendrikThePendric Aug 27, 2024
9fe54ed
chore: resizing the container
HendrikThePendric Sep 2, 2024
d31e050
chore: scaling the icon correctly
HendrikThePendric Sep 4, 2024
16280c1
fix: rework old implementation WIP
HendrikThePendric Sep 4, 2024
3c67d83
chore: align single value store with other highcharts charts
HendrikThePendric Sep 10, 2024
9b199b5
chore: clean up comments and console log
HendrikThePendric Sep 10, 2024
6eaab34
chore: switch to highcharts adapter in story
HendrikThePendric Sep 11, 2024
f7bfcfb
feat: add generic mechanism for rendering custom SVGs on chart load e…
HendrikThePendric Sep 11, 2024
6b6a204
fix: implement subtitle and title logic for single value chart
HendrikThePendric Sep 11, 2024
2d5d627
refactor: implement single value config via Highcharts adapter
HendrikThePendric Sep 12, 2024
4b3284e
fix: set subtext in customSVGOptions
HendrikThePendric Sep 12, 2024
8546b95
chore: positioning WIP
HendrikThePendric Sep 17, 2024
ec91ff2
chore: position all SVG elements using Highcharts SVGElement.align()
HendrikThePendric Sep 18, 2024
250e7f0
chore: remove files from failed initial re-implementation
HendrikThePendric Sep 18, 2024
9f50432
chore: re-enable no-unused-vars ESLint rule and address related issues
HendrikThePendric Sep 18, 2024
d165810
chore: update background to white when exporting and background is tr…
HendrikThePendric Sep 18, 2024
543eb31
chore: give icon the same height as value text
HendrikThePendric Sep 19, 2024
4de5b8b
chore: adjust story so all scenarios can be tested
HendrikThePendric Sep 19, 2024
16474d6
fix: prevent checkIfFitsWithinContainer throwing an error when subtex…
HendrikThePendric Sep 19, 2024
48cb4f5
chore: reduce subtext size
HendrikThePendric Sep 19, 2024
71ee971
fix: multiline subtitle in dashboard view
HendrikThePendric Sep 19, 2024
131256e
chore: adjust story styles
HendrikThePendric Sep 19, 2024
ff357ed
fix: adjust dashboard title styles to original implementation
HendrikThePendric Sep 19, 2024
9f55258
chore: remove console.log
HendrikThePendric Sep 23, 2024
1ed2e9a
fix: set spacingTop correctly if both title and subtitle are missing
HendrikThePendric Sep 24, 2024
de5300e
chore: prevent crash when legend is being displayed
HendrikThePendric Sep 24, 2024
210a844
fix: correctly pass legendOptions to getSingleValueBackgroundColor
HendrikThePendric Sep 24, 2024
4c2dd49
fix: set value color correctly based on legend color
HendrikThePendric Sep 24, 2024
17cc4d3
fix: compute text color correctly
HendrikThePendric Sep 24, 2024
1a735b7
chore: allow exporting PNG and PDF from single value story
HendrikThePendric Oct 9, 2024
c301dd0
chore: use SVGRenderer to draw the icon
HendrikThePendric Oct 9, 2024
922eee8
fix: whitelist some SVG attributes needed by the single value visuali…
HendrikThePendric Oct 9, 2024
267aa20
fix: address cross-browser style issues by using kebab-cased attribut…
HendrikThePendric Oct 10, 2024
35f4865
fix: use normal font weight during PDF export to prevent serif font s…
HendrikThePendric Oct 10, 2024
347b4e1
fix: force reload the getBBox call to prevent getting stale dimensions
HendrikThePendric Oct 10, 2024
36a2abd
fix: avoid having to read this.userOptions.customSVGOptions for all v…
HendrikThePendric Oct 14, 2024
6702cb2
chore: remove stray console.log
HendrikThePendric Oct 15, 2024
550c7ed
fix: add plugin provided by highcharts support that solves text shado…
HendrikThePendric Oct 16, 2024
d9de091
refactor: rename isPDF and isExportingToPDF to isPdfExport
HendrikThePendric Oct 16, 2024
25ce7b3
fix: add plugin to fix nonASCII font bug and combine pdf export bugfi…
HendrikThePendric Oct 16, 2024
0e739dd
chore: adjust comments for clarity
HendrikThePendric Oct 16, 2024
72e25fa
chore: add data-test attributes to single value svg elements
HendrikThePendric Oct 17, 2024
344b649
fix: adjust SV render styles
cooper-joe Oct 17, 2024
9a5f27e
fix: ensure title and subtitle color are computed correctly
HendrikThePendric Oct 17, 2024
cb1e77c
fix: ensure title and subtitle use custom color also for dark background
HendrikThePendric Oct 17, 2024
71b6db7
chore: move shouldUseContrastColor to general utils dir
HendrikThePendric Oct 21, 2024
9380a0c
fix: address problem in demo story pdf export
HendrikThePendric Oct 21, 2024
1d89e05
refactor: append icon children to iconGroup using native DOM API
HendrikThePendric Oct 21, 2024
3065022
refactor: restructure chart, event and customSVGOptions dirs
HendrikThePendric Oct 21, 2024
fa6f221
refactor: hide no-data text by clearing string instead of setting opa…
HendrikThePendric Oct 22, 2024
2cb6b56
chore: remove old single value code (#1703)
HendrikThePendric Oct 22, 2024
2f2217b
chore: adjust initial subtext state in story, so it matches dropdown
HendrikThePendric Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .storybook/preview-head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<link rel="preconnect" href="https://fonts.googleapis.com" />
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin />
<link
href="https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&display=swap"
rel="stylesheet"
/>
Loading
Loading