fix: avoid crash in DV with some chart types (DHIS2-15882) #1582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-15882
Relates to https://github.com/dhis2/data-visualizer-app/pull/XXX
Key features
legendItem
Description
Highcharts changed the internal structure of the
legendItem
object from version 10.3.1.Before there were 3 properties:
legendItem
,legendSymbol
andlegendGroup
.Now
legendItem
containslabel
(previouslylegendItem
),group
(previouslylegendGroup
) and (apparently)symbol
(previouslylegendSymbol
).We use this internal object for handling custom legend symbols.
This fixes the crash in DV when using certain chart types (column, stacked column, bar, stacked bar).
TODO
legendItem
is different than what we see in DV app wherelegendSymbol
is still present andlegendItem
contains onlygroup
andlabel
Known issues
the legend symbol is not renderedsolved hereScreenshots
Before:
After: