fix: show warning text below RichTextEditor when unable to show snapshot #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikThePendric
force-pushed
the
DHIS2-15781-show-warning-text-below-rich-text-editor
branch
from
8493077 to
f20a361
Compare
edoardo
reviewed
Sep 14, 2023
src/components/Interpretations/InterpretationsUnit/InterpretationForm.js
Outdated
Show resolved
Hide resolved
edoardo
approved these changes
Sep 14, 2023
1 task
Without this default value the changes in this PR would actually constitute to a breaking change, at least for the line-listing-app: if the `visualizationHasTimeDimension` prop is not provided and the `type` equals `eventVisualization`, the helptext would be rendered. By defaulting to `true` we avoid this, only explicitly setting `visualizationHasTimeDimension` to `false` will cause the help text to show. I think this is mainly a theoretical issue, because the line-listing-app will always set the prop. But who knows: there could be a 3rd party app out there using the analytics library which would break because of this.
Co-authored-by: Edoardo Sabadelli <[email protected]>
HendrikThePendric
force-pushed
the
DHIS2-15781-show-warning-text-below-rich-text-editor
branch
from
37eb41c to
7dd3d31
Compare
|
Superseded by the combo PR #1588 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-15781
Relates to dhis2/line-listing-app#428
Key features
eventVisualization(line-listing-app) if no time dimension is available.Screenshots
supporting text