fix: remove eslint disable and fix useEffect dep list

dhis2 · Aug 9, 2024 · cd99b54 · cd99b54
1 parent 1e9dda2
commit cd99b54
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/src/components/DashboardPluginWrapper/DashboardPluginWrapper.js b/src/components/DashboardPluginWrapper/DashboardPluginWrapper.js
@@ -29,11 +29,7 @@ const CacheableSectionWrapper = ({ id, children, isParentCached }) => {
             // -- a back-up to imperative `removeCachedData`
             remove()
         }
-
-        // NB: Adding `startRecording` to dependencies causes
-        // an infinite recording loop as-is (probably need to memoize it)
-        // eslint-disable-next-line react-hooks/exhaustive-deps
-    }, [isParentCached])
+    }, [isCached, isParentCached, remove, startRecording])
 
     return (
         <CacheableSection id={id} loadingMask={<LoadingMask />}>