Skip to content

Commit

Permalink
fix: adjustments to heights and positions in ItemSelector (#17)
Browse files Browse the repository at this point in the history
Fixes include:

* reduce height of ItemSelector by 24px so that the total height of the dialog stays under 768px which is our minimum supported resolution.
* adjust position of the "Select" button by a few pixels
* a few other small pixel adjustments to attempt to ensure that odd browsers are less likely to show a scrollbar.
  • Loading branch information
jenniferarnesen authored Apr 23, 2019
1 parent 5692ba4 commit 1edfdac
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
6 changes: 3 additions & 3 deletions src/components/ItemSelector/styles/ItemSelector.style.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,16 @@ export default css`
border: 1px solid ${colors.greyLight};
display: flex;
flex-direction: column;
height: 534px;
height: 510px;
position: relative;
}
.unselected {
margin-right: 55px;
width: 419px;
width: 418px;
}
.selected {
width: 277px;
width: 276px;
}
`
1 change: 0 additions & 1 deletion src/components/ItemSelector/styles/SelectedItems.style.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import css from 'styled-jsx/css'
export default css`
.selected-list {
flex: 1;
height: 455px;
list-style: none;
margin: 0px;
overflow-y: auto;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default css`
}
.select-highlighted-button {
left: 429px;
left: 426px;
position: absolute;
top: 230px;
}
Expand Down

0 comments on commit 1edfdac

Please sign in to comment.